Simplify template generation and handling #3683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
andrewkroh
approved these changes
Feb 27, 2017
| } | ||
| existingFiles = append(existingFiles, f) | ||
| if _, err := os.Stat(*file); err != nil { | ||
| fmt.Fprintf(os.Stderr, "Input -file does not exist: %s", *file) |
There was a problem hiding this comment.
os.Stat could fail for reasons other than the file does not exists. You can test for that specific case with os.IsNotExist or maybe you could just include the error message from stat in the output.
There was a problem hiding this comment.
I will just include the error, because i think all errors should be covered.
* Only one file is passed instead of an array as now only file is needed. Introduce `-file` param. * Local loading of beats version was removed as it can lean to cyclic imports * Move `_meta/fields.full.generated.yml` to `fields.yml` in preparation for packaging `fields.yml` and ignore it in git * Cleanup Template generation package * Rename -beat.name param to -index as this describes it better Part of elastic#3654
ruflin
force-pushed
the
simplify-template
branch
from
c83acfd to
e29ce83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-fileparam._meta/fields.full.generated.ymltofields.ymlin preparation for packagingfields.ymland ignore it in gitPart of #3654